Refactor: rename matcher.js to create-matcher.js #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the poorly named function
match
inmatcher.js
tocreateMatcher
increate-matcher.js
, which better describes what the function does.It is already exported as
samsam.createMatcher
, so no new release is required.Background
I am trying to cover this library in JSDoc comments, understanding what this function does has always been a struggle.
This has been unlocked by #84, which fixed
is-element.test.js
to not fail when load order changes.This PR paves the way for #82
Solution
Rename the file(s) and the name of the function that is exported (not the name it is exported under though).
How to verify - mandatory
Checklist for author
npm run lint
passes