Re-introduce version script #2437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was inadvertently removed during merge conflicts, and is required for any of the new release process stuff to work
Otherwise this is just gonna keep popping up
|
Ugh, sorry, wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR)
Because of the merge mess with #2426, the
versioncommand inpackage.jsonwas reverted, so that the newversion.shscript isn't being used.Solution
This PR also puts the
version.shscript back, and persists a prettier fix in a generated file back to the generation of the file, so it doesn't keep popping up.How to verify - mandatory
The only way to really, test this is to run
npm version, but if #2436 is merged first, then we'll have a way to run that without publishing a release!Checklist for author
npm run lintpasses