Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce version script #2437

Closed

Conversation

cincodenada
Copy link
Contributor

Purpose (TL;DR)

Because of the merge mess with #2426, the version command in package.json was reverted, so that the new version.sh script isn't being used.

Solution

This PR also puts the version.sh script back, and persists a prettier fix in a generated file back to the generation of the file, so it doesn't keep popping up.

How to verify - mandatory

The only way to really, test this is to run npm version, but if #2436 is merged first, then we'll have a way to run that without publishing a release!

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

This was inadvertently removed during merge conflicts, and is required
for any of the new release process stuff to work
Otherwise this is just gonna keep popping up
@cincodenada cincodenada changed the title Fix version and dry run Re-introduce version script Jan 28, 2022
@cincodenada
Copy link
Contributor Author

Ugh, sorry, wrong branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant