Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling non-configurable object descriptors on the prototype #2508

Merged
merged 6 commits into from
Apr 20, 2023
Merged

Handling non-configurable object descriptors on the prototype #2508

merged 6 commits into from
Apr 20, 2023

Commits on Apr 20, 2023

  1. regression test for sinonjs#2491

    @fatso83
    fatso83 committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    b4bf432 View commit details
    Browse the repository at this point in the history

  2. fix: ensure we can always restore our own spies

    @fatso83
    fatso83 committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    8431901 View commit details
    Browse the repository at this point in the history

  3. Add tests for mocks, fakes and stubs 

    This shows an incoherent appraoch to how we deal with object
descriptors across different code paths.
    @fatso83
    fatso83 committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    24e2877 View commit details
    Browse the repository at this point in the history

  4. fix: only bother with unconfigurable descriptors if they are our own

    @fatso83
    fatso83 committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    0a8b32d View commit details
    Browse the repository at this point in the history

  5. remove test for sandbox.replace 

    never supported undefined or protypal props in the first place.
See sinonjs#2195 for backing discussion on creating sinon.define()
    @fatso83
    fatso83 committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    aa9662b View commit details
    Browse the repository at this point in the history

  6. fix linting

    @fatso83
    fatso83 committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    040b144 View commit details
    Browse the repository at this point in the history