Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase #replace.usingAccessor for DI in the typescript case study #2556

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

fatso83
Copy link
Contributor

@fatso83 fatso83 commented Oct 18, 2023

Purpose (TL;DR) - mandatory

This adds how you can improve upon the manual DI situation using the new replace

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@c47a4be). Click here to learn what that means.

❗ Current head 5028354 differs from pull request most recent head 2692674. Consider uploading reports for the commit 2692674 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2556   +/-   ##
=======================================
  Coverage        ?   96.03%           
=======================================
  Files           ?       40           
  Lines           ?     1916           
  Branches        ?        0           
=======================================
  Hits            ?     1840           
  Misses          ?       76           
  Partials        ?        0           
Flag Coverage Δ
unit 96.03% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cp -rl was wonky on macOS. rsync worked much better.
Makes the release available on http://127.0.0.1:4000/releases/dev/release/
Husky has not been working for some time.
Has turned way too complicated
@fatso83 fatso83 merged commit ff0e993 into main Oct 18, 2023
10 checks passed
@fatso83 fatso83 deleted the update-article branch October 18, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant