Fixed Null Pointer Exception when downloading a drive doc/sheet that … #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…exists on the local machine.
It appears that remote Google docs and sheet return a file size of 0. So, when comparing the sizes the local (converted to Open Office) document will always have a different size than the local copy. This causes the
performChecksumCheck()
to returnnull
on the remote file, throws an exception and then skips the file. Since we don't know for sure if the remote file is different than the local file, I think it would be better to download the file again.Another enhancement could be an additional parameter
--only-check-last-modified
so that the file size and checksum are not also validated. This would prevent downloading files that have the same modification date (but could potentially be different).Here is the stack trace that this commit fixes: