Add C# reference implementation #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sipa can you merge that ? |
sipa
reviewed
Aug 4, 2017
ref/csharp/Program.cs
Outdated
|
|
||
| private static byte[] Scriptpubkey(byte witver, byte[] witprog) | ||
| { | ||
| var v = witver > 0 ? witver + 0x80 : 0; |
NicolasDorier
force-pushed
the
csharp
branch
2 times, most recently
from
cc505ce
to
03edfbd
Compare
|
Updated and fixed the tests |
|
Anything left for merging ? |
|
@NicolasDorier Sorry for the slow response here... I would rather avoid having the full error location logic in the reference implementation (which is intended to be lean and understandable, and easily copy-pastable and into your own project). There is a separate ecc directory for the error correction code. |
NicolasDorier
force-pushed
the
csharp
branch
from
03edfbd
to
26feece
Compare
|
Removed code error correction code |
|
Pay P33LL0 |
ref/csharp/Bech32Encoder.cs
Outdated
| return chk; | ||
| } | ||
|
|
||
| bool VerifyChecksum(byte[] data, int bechStringLen) |
There was a problem hiding this comment.
bechStringLen is never used.
ref/csharp/Bech32Encoder.cs
Outdated
| throw new FormatException("bech chars are out of range"); | ||
| } | ||
|
|
||
| buffer = Encoding.ASCII.GetBytes(encoded); |
There was a problem hiding this comment.
(nitpicking) buffer is already set in line 315
|
Thanks @Coding-Enthusiast , fixed. |
|
@sipa do you intend to merge this one day? |
|
Spring cleaning, ping me if you feel like merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Bech32 with error detection in C#.