Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make account approval status action show "return applied date" in the provisional column when "check if provisional is off" #158

Open
siphomateke opened this issue Aug 25, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@siphomateke
Copy link
Owner

Is your feature request related to a problem? Please describe.
Differentiating provisional and annual returns is really necessary. When "check if provisional" is on, this is quite easy. But since the action takes quite a bit longer to run when this setting is enabled, a faster alternative would be nice.

Describe the solution you'd like
It is somewhat possible to deduce if returns are provisional by looking at the "return applied date" column in the return history table. Thus, showing this column when "check if provisional" is disabled would allow the user to still tell if returns are provisional without the performance hit.

Additional context
#153

@siphomateke siphomateke added the enhancement New feature or request label Aug 25, 2019
siphomateke added a commit that referenced this issue Aug 25, 2019
This is only a partial implementation of #158. Since the client action system isn't really setup to allow outputs to read their corresponding action's inputs, always showing the column will have to do for now.
@siphomateke
Copy link
Owner Author

This is partially fixed by a8efe58. Due to a technical limitation, columns in an action's output can't be dynamically added based on its input. Until that is addressed, the "return applied date" column will always be shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant