Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The global ok is removed in QUnit 2.0. #9

Closed
lancedikson opened this issue Jan 5, 2017 · 1 comment · Fixed by #10
Closed

The global ok is removed in QUnit 2.0. #9

lancedikson opened this issue Jan 5, 2017 · 1 comment · Fixed by #10

Comments

@lancedikson
Copy link
Contributor

Ran out into the problem with tests in my Ember app after installed ember-cli-sass-lint. ember test says:

not ok 23 PhantomJS 2.1 - Sass Lint - boilerplate: boilerplate/_foundation-settings.scss should pass sass-lint
    ---
        actual: >
            null
        stack: >
            http://localhost:7357/assets/test-support.js:4381:133
            http://localhost:7357/assets/tests.js:161:7
            runTest@http://localhost:7357/assets/test-support.js:3490:34
            run@http://localhost:7357/assets/test-support.js:3476:13
            http://localhost:7357/assets/test-support.js:3650:15
            process@http://localhost:7357/assets/test-support.js:4712:26
            begin@http://localhost:7357/assets/test-support.js:4695:11
            http://localhost:7357/assets/test-support.js:4064:11
        message: >
            Died on test #1 http://localhost:7357/assets/tests.js:160:13
            exports@http://localhost:7357/assets/vendor.js:132:37
            requireModule@http://localhost:7357/assets/vendor.js:32:25
            require@http://localhost:7357/assets/test-support.js:7104:14
            loadModules@http://localhost:7357/assets/test-support.js:7096:21
            load@http://localhost:7357/assets/test-support.js:7126:33
            http://localhost:7357/assets/test-support.js:7009:22: The global `ok` is removed in QUnit 2.0.
            Details in our upgrade guide at https://qunitjs.com/upgrade-guide-2.x/

I've found the bug. Will send you a PR for it now.

@RobbieTheWagner
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants