-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache duplicate HTTP requests #7
base: master
Are you sure you want to change the base?
Conversation
I think I found the problem with my proxy-fetch technique. Using I will probably need to redesign the caching system to cache decoded response data rather than the Response object itself. |
Refactored to cache responses instead. |
c9542e4
to
00776ce
Compare
Rebased onto v3 |
The current problem, I believe, is that groups of secondary API requests are made async, and all called at once, such that it's difficult to have the data returned by one used by the others. The requests should probably be de-duplicated by URL before they are sent out. |
This is a revised version of #5 which did not actually work.
Fixes #3
To do:
getNotifications
rather than onfetchNotifications
?null
for the URL in gitnews-cli. Not sure why.