Forget the name of the global functions on restore #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new global function is defined, we skip if the function has been defined already (by looking at self::$global_functions). But they don't clear the memory when the original definition is restored, so after restoration, re-defining doesn't work because the name is found self::$global_functions.
sirbrillig
approved these changes
Feb 8, 2022
mehamasum
added a commit
to mehamasum/spies
that referenced
this pull request
Feb 9, 2022
This was referenced Feb 9, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
When a new global function is defined, we skip if the function has been defined already (by looking at
self::$global_functions).But we don't clear the memory when the original definition is restored, so after restoration, re-defining doesn't work because the name is found
self::$global_functions.