siren-0.8.x bump netty 4.1.27-3 #9
Conversation
| @@ -18,7 +18,7 @@ | |||
|
|
|||
| package org.apache.arrow.vector; | |||
|
|
|||
| import io.netty.buffer.ArrowBuf; | |||
| import siren.io.netty.buffer.ArrowBuf; | |||
There was a problem hiding this comment.
Does that mean we weren't always using the custom changes of netty we did ?
There was a problem hiding this comment.
Yes, for vector, but this was fixed after this release 0.8.0
| @@ -53,20 +53,20 @@ | |||
| <subscribe>dev-subscribe@arrow.apache.org</subscribe> | |||
| <unsubscribe>dev-unsubscribe@arrow.apache.org</unsubscribe> | |||
| <post>dev@arrow.apache.org</post> | |||
| <archive>http://mail-archives.apache.org/mod_mbox/arrow-dev/</archive> | |||
| <archive>https://mail-archives.apache.org/mod_mbox/arrow-dev/</archive> | |||
There was a problem hiding this comment.
You're right, this is not needed, event if the good url is with the https. Shall I revert ?
There was a problem hiding this comment.
I think it's better to leave it as it is originally, this way we have less changes.
You're right, the PR should probably be renamed. For what I could see, the release 0.8.0 was not a "ready to use" project (even if good for third parties of course), it was not compiling as is when going to snapshot due to package rename (via shade plugin). This was fixed after this release, so nothing to report to master branch. |
From a deadlocked run... ``` #0 0x00007f8a5d48dccd in __lll_lock_wait () from /lib64/libpthread.so.0 #1 0x00007f8a5d486f05 in pthread_mutex_lock () from /lib64/libpthread.so.0 #2 0x00007f8a566e7e89 in arrow::internal::FnOnce<void ()>::FnImpl<arrow::Future<Aws::Utils::Outcome<Aws::S3::Model::ListObjectsV2Result, Aws::S3::S3Error> >::Callback<arrow::fs::(anonymous namespace)::TreeWalker::ListObjectsV2Handler> >::invoke() () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so #3 0x00007f8a5650efa0 in arrow::FutureImpl::AddCallback(arrow::internal::FnOnce<void ()>) () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so #4 0x00007f8a566e67a9 in arrow::fs::(anonymous namespace)::TreeWalker::ListObjectsV2Handler::SpawnListObjectsV2() () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so #5 0x00007f8a566e723f in arrow::fs::(anonymous namespace)::TreeWalker::WalkChild(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int) () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so #6 0x00007f8a566e827d in arrow::internal::FnOnce<void ()>::FnImpl<arrow::Future<Aws::Utils::Outcome<Aws::S3::Model::ListObjectsV2Result, Aws::S3::S3Error> >::Callback<arrow::fs::(anonymous namespace)::TreeWalker::ListObjectsV2Handler> >::invoke() () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so #7 0x00007f8a5650efa0 in arrow::FutureImpl::AddCallback(arrow::internal::FnOnce<void ()>) () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so #8 0x00007f8a566e67a9 in arrow::fs::(anonymous namespace)::TreeWalker::ListObjectsV2Handler::SpawnListObjectsV2() () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so #9 0x00007f8a566e723f in arrow::fs::(anonymous namespace)::TreeWalker::WalkChild(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int) () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so #10 0x00007f8a566e74b1 in arrow::fs::(anonymous namespace)::TreeWalker::DoWalk() () from /arrow/r/check/arrow.Rcheck/arrow/libs/arrow.so ``` The callback `ListObjectsV2Handler` is being called recursively and the mutex is non-reentrant thus deadlock. To fix it I got rid of the mutex on `TreeWalker` by using `arrow::util::internal::TaskGroup` instead of manually tracking the #/status of in-flight requests. Closes apache#9842 from westonpace/bugfix/arrow-12040 Lead-authored-by: Weston Pace <weston.pace@gmail.com> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
No description provided.