Berkelium should check if a glib thread isn't already running #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pplications (like ours) might already have their threads running before initializing Berkelium. This if is mandatory to avoid a crash if the application did the g_thead_init() before initalizing Berkelium. I tested this in our application, all seems fine. Also I made sure if it's not Berkelium that initialized the thread, it shouldn't impose the main window title either (like it is doing when it will init the thread itself).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most applications (like ours) might already have their threads running before initializing Berkelium.
This if is mandatory to avoid a crash if the application did the g_thead_init() before initalizing Berkelium.
I tested this in our application, all seems fine. Also I made sure if it's not Berkelium that initialized the thread, it shouldn't impose the main window title either (like it is doing when it will init the thread itself).