Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for gzipped files #13

Closed
Adafede opened this issue Nov 19, 2020 · 3 comments
Closed

support for gzipped files #13

Adafede opened this issue Nov 19, 2020 · 3 comments
Labels

Comments

@Adafede
Copy link

Adafede commented Nov 19, 2020

Hi!

Wonderful work on Sirius 4.5.0!

I am used to working with mzML.gz files with my other pipelines without problems, would it be possible to support importing them gzipped?

Best,

@mfleisch
Copy link
Contributor

Hey,
I think we cannot support gzipped mzml in a efficient manner. We are relying on jmzml for parsing mzml and do not want to change this. Jmzml is using an index on the mzml file to efficiently access specific XML objects.

Therefore we cannot pass a compressed Stream directly into the File parser.

One thing we could do is extracting the compressed input in some temp directory before parsing. But I do not see how this improves anything compared to doing the same step beforehand on the command line.
Would that help anyhow?

@Adafede
Copy link
Author

Adafede commented Nov 25, 2020

It is not a real issue...was only a question since many tools support it, your answer clarifies why it is not the case, and should not be a problem at all...just some Go to store :D

Thank you for your answer!

@mfleisch
Copy link
Contributor

Ok, then we leave it "unfixed" for now.

mfleisch pushed a commit that referenced this issue Mar 8, 2024
Resolve "Transform GUI to Nightsky API"

Closes #81, #123, #87, #84, #83, #60, #44, #42, #27, #16, #13, and #11

See merge request bright-giant/sirius/sirius-frontend!26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants