Block/card upload document #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@all-contributors please add @bazsup for code. |
|
I've put up a pull request to add @bazsup! 🎉 |
siriwatknp
reviewed
Oct 30, 2023
siriwatknp
reviewed
Oct 30, 2023
Comment on lines
22
to
23
| <div {...getRootProps()}> | ||
| <Card |
There was a problem hiding this comment.
Suggested change
| <div {...getRootProps()}> | |
| <Card | |
| <Card | |
| {...getRootProps()} |
It's better to spread the props directly to the card
There was a problem hiding this comment.
I encountered a TypeScript error while attempting to spread the props into the Card component."
There was a problem hiding this comment.
Found a way to make TypeScript happy in eccf23b:
<Card
{...(getRootProps() as Omit<DropzoneRootProps, "color">)}
variant="plain"
sx={{ minWidth: 300, borderRadius: "xl", boxShadow: "lg" }}
size="sm"
>
siriwatknp
reviewed
Oct 30, 2023
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com>
|
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #78
Hi @siriwatknp,
⚠️ I have added the
react-dropzonelibrary for dragging files to the card. Please take a look.