Fix/docker readme #638
Merged
Fix/docker readme #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesLichtenberger
approved these changes
Jul 10, 2023
konketf
pushed a commit
to konketf/sirix
that referenced
this pull request
Jul 12, 2023
JohannesLichtenberger
pushed a commit
that referenced
this pull request
Jul 13, 2023
* readability * Refactor: enhanced for loop * typo fix, added a type test, added a check to avoid NullPointerException, added logger * fix:remove extra line in docker readme (#638) --------- Co-authored-by: Amin Malek Mohammadi <76443257+aminmalek@users.noreply.github.com>
JohannesLichtenberger
pushed a commit
that referenced
this pull request
Jul 14, 2023
* readability * Refactor: enhanced for loop * typo fix, added a type test, added a check to avoid NullPointerException, added logger * fix:remove extra line in docker readme (#638) * typo in method * minor fix * reordered modifiers * final method in final class * Condition 'v2 != null' is always 'true' when reached * final method in final class * identical method * final method in final class * null check * null checks and redundant conditional * null check * added a private constructor, error messages --------- Co-authored-by: Amin Malek Mohammadi <76443257+aminmalek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I deleted the extra line in readme file that said add the docker.internal to the conf file.