Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get Parboiled2 to compile with Scala-JS #77

Closed
bblfish opened this issue Jun 9, 2014 · 14 comments
Closed

get Parboiled2 to compile with Scala-JS #77

bblfish opened this issue Jun 9, 2014 · 14 comments

Comments

@bblfish
Copy link

bblfish commented Jun 9, 2014

http://www.scala-js.org/ is moving along very quickly. Having a good parser on the client would be very neat. As Parboiled2 is pure Scala, it should be possible to get it to work for Scala-JS. :-)

@sjrd
Copy link

sjrd commented Jun 9, 2014

Note: there has been some wip attempt at porting it to Scala.js already:

@alexander-myltsev
Copy link
Contributor

I managed to launch very old and yet simple version on Scala-JS. Need more time to make recent parboiled2 to live atop Scala-JS. I will be keeping you updated, guys. Appreciate your patience.

@sirthias
Copy link
Owner

sirthias commented Jun 9, 2014

I must admit that I haven't worked with scaja-js myself yet.
However, I'd be more than happy to assist with establishing compatibility. Please let me know if there is anything that you think I can do to help.

@alexander-myltsev
Copy link
Contributor

Thank you, @sirthias! I will certainly ask help from you if required.

@alexander-myltsev
Copy link
Contributor

This can be closed.

@danielwegener
Copy link

Uhm. Just curious. Will it be ported back to this repo and released in central? :)

@sirthias
Copy link
Owner

Daniel, I currently don't have time to pick this up, but the next pb2 version will be scala-js compatible by itself...

@danielwegener
Copy link

Hi Matthias :) No rush, I just was worried about the "can be closed" comment - I just read it as "nvm, solved in a fork".

@mravey
Copy link

mravey commented Dec 3, 2015

@sirthias that'd be really cool ! Do you have any idea when the next version of pb2 will be released ?

@vhiairrassary
Copy link

@matthieu-ravey pb2 should be released soon: 25f937b

@vhiairrassary
Copy link

@sirthias Hello, we are working on adding support scala.js to pb2 but as scala.js does not support java sources the file Base64.java cannot be compiled.

Will you be ok to merge a pull request that rewrite it in scala + add support to scala.js in build.sbt ? (Just commenting Base64Parsing.scala which is the alone class to use Base64.java allowed us to use pb2 in js and it rocks !)

@sirthias
Copy link
Owner

Victor, yes, having a proper port of Base64.java to Scala would be great.
Maybe it could even be done almost automatically, IntelliJ appears to have an automatic converter that could maybe provide at least a good basis for the port.

@vhiairrassary
Copy link

@sirthias #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants