Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed 2 bugs. #133

Closed
wants to merge 4 commits into from
Closed

fixed 2 bugs. #133

wants to merge 4 commits into from

Conversation

spance
Copy link
Contributor

@spance spance commented May 25, 2014

Update Parser.java …
fixed about the tableCell parse ,then can calculate colspan number correctly.
Update ToHtmlSerializer.java …
fixed about unnecessary char when output image node's end tag.

fixed table td cell setColspan bug.
then can be use continuous pipe symbol to set right ColSpan number.
fixed printImageTag of end tag use wrong html symbols.
@sirthias
Copy link
Owner

Thanks for this PR.
Could you change the commit messages to something meaningful that expresses what the change is about semantically?

printImageTag test in ToHtmlSerializerTest added .
add pom.xml for every maven user.
@spance
Copy link
Contributor Author

spance commented Jun 1, 2014

Why didn't pay attention to this change? Some files has been submitted for a long time.

@sirthias
Copy link
Owner

sirthias commented Jun 1, 2014

Thanks for this patch and sorry for not having merged it yet.
I am very busy on other fronts right now and don't have any capacity for pegdown at the moment.
I'll come back to this ASAP.

@spance
Copy link
Contributor Author

spance commented Jun 2, 2014

yeah. Thanks.

@sirthias
Copy link
Owner

Cheery-picked second commit.
Thanks!

@sirthias sirthias closed this Feb 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants