-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds pre-commit configuration #2
Conversation
This enables using the repository with [pre-commit][1]. [1]: https://pre-commit.com
Once this is merged, someone (me?) could put a PR on https://github.com/pre-commit/pre-commit.com/blob/main/all-repos.yaml that adds |
@colindean Thanks for creating this PR! The output implies that the command is scanning the |
I tested with
and just again by writing the config output by the try-repo command as a local test with
and I think you're right: I think pre-commit is cd'ing elsewhere. pre-commit's I'll troubleshoot when I get a chance; greatest risk of merging this now is that the ignore file will be… ignored. Inconvenient but could be noted in the README until we/I get this ironed out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been able to reproduce the lack of ignoring locally, and it's not related to pre-commit
at all. Basically if you pass a file as an argument that will override the ignorefile. I need to figure out the best solution but agree it's unrelated to this change.
@sirwart reports the operation is faster because of `secrets`' internal parallelization. Co-authored-by: Brian Smith <ohohvi@gmail.com>
This enables using the repository with pre-commit.
I tested this with
And the output: