Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Issue #56: Bring Vec.jl as submodule. #76

Merged
merged 4 commits into from Mar 20, 2020
Merged

Conversation

raunakbh92
Copy link
Collaborator

Copied source code from Vec.jl as a folder in AutomotiveDrivingModels.jl/src and incorporated Vec.jl as a submodule within AutomotiveDrivingModels.jl.

Caveat: Still relies on using Records.jl as a dependency. Please see branch incorporate_records which is targeted at incorporating Records into AutomotiveDrivingModels.

…ecords.jl as a dependency. Please see branch incorporate_records
@raunakbh92 raunakbh92 changed the title Issue #56: Bring Vec.jl as submodule. [WIP ]Issue #56: Bring Vec.jl as submodule. Mar 18, 2020
@raunakbh92 raunakbh92 changed the title [WIP ]Issue #56: Bring Vec.jl as submodule. [WIP] Issue #56: Bring Vec.jl as submodule. Mar 18, 2020
@coveralls
Copy link

coveralls commented Mar 18, 2020

Coverage Status

Coverage decreased (-1.2%) to 74.959% when pulling 2899b91 on incorporate_vec into bf47a45 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-20.4%) to 55.695% when pulling a7209f5 on incorporate_vec into bf47a45 on master.

@MaximeBouton MaximeBouton mentioned this pull request Mar 19, 2020
17 tasks
@MaximeBouton
Copy link
Member

I think this is good to merge.
I don't know why the apple jobs on travis are stuck...

@MaximeBouton MaximeBouton merged commit 94a1dd8 into master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants