Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register in General #56

Closed
MaximeBouton opened this issue Jan 31, 2020 · 0 comments
Closed

Register in General #56

MaximeBouton opened this issue Jan 31, 2020 · 0 comments
Labels
v0.8
Milestone
v0.8

Comments

@MaximeBouton
Copy link
Member

It might be worth registering this package to julia General Registry.

I think the main limitation is the dependencies in Vec.jl and Records.jl.

Here are my suggestions:
option 1:
Register Vec to General (under another name), make Records.jl a submodule of AutomotiveDrivingModels.jl, register AutomotiveDrivingModels

  • Vec has a lot of overlapping functionalities with existing julia package (unsure if that is a real issue, if we have appropriate naming)
  • Vec is not really used outside of AutomotiveDrivingModels

option 2:
Make both Vec and Records submodules of AutomotiveDrivingModels.

  • Requires a bit less effort
  • Might be easier to maintain

I prefer option 2, as Vec and Records are not used anywhere else, and it might lead to less confusion for users about where datastructures like Frame, Entity or VecSE2 are defined.

Thoughts?
@MaximeBouton MaximeBouton mentioned this issue Mar 2, 2020
Closed
17 tasks
raunakbh92 added a commit that referenced this issue Mar 9, 2020
@raunakbh92
Issue #56: Started to incorporate records
6a7fb0c 
Pulled in all the code from Records.jl/src except for common.jl.
Did not pull in Records.jl/test
AutomototiveDrivingModels.jl tests pass locally
Still using external Records.jl package
raunakbh92 added a commit that referenced this issue Mar 10, 2020
@raunakbh92
Issue #56: Bring Vec.jl as submodule. Caveat: Still relies on using R…
a7209f5 
…ecords.jl as a dependency. Please see branch incorporate_records
exoticDFT added a commit that referenced this issue Mar 10, 2020
@exoticDFT
Issue #56: Adds Records/src/common.jl to package
f28d6fe 
- Adds the Records/src/common.jl file that contains IO functions for Records objects.
exoticDFT added a commit that referenced this issue Mar 10, 2020
@exoticDFT
Issue #56: Removes the need for external Records.jl package
766f0ae 
- Removes the external Records import in the ADM package.
- Exports all the "records" functions, types, etc.
- Removes need for calling "Records" module in interface.jl.
@MaximeBouton MaximeBouton added this to the v0.8 milestone Mar 11, 2020
MaximeBouton added a commit that referenced this issue Mar 20, 2020
@MaximeBouton
Merge pull request #76 from sisl/incorporate_vec
94a1dd8 
[WIP] Issue #56: Bring Vec.jl as submodule.
MaximeBouton added a commit that referenced this issue Mar 21, 2020
@MaximeBouton
Merge pull request #78 from sisl/incorporate_records
52740c5 
[WIP] Issue #56: Move Records.jl into ADM Package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v0.8
Projects
None yet
Milestone
v0.8
Development

No branches or pull requests
1 participant
@MaximeBouton