[WIP] Issue #56: Move Records.jl into ADM Package #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulled in all the code from Records.jl/src except for common.jl. Did not pull in Records.jl/test AutomototiveDrivingModels.jl tests pass locally Still using external Records.jl package
- Adds the Records/src/common.jl file that contains IO functions for Records objects.
- Removes the external Records import in the ADM package. - Exports all the "records" functions, types, etc. - Removes need for calling "Records" module in interface.jl.
|
[edit] Let's actually use this PR to move the Records stuff around |
Remove QueueRecord and ListRecord
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are moving the source code from SISL/Records.jl into this package.