Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ptr to UInt instead of Int in missing C macros #24

Merged
merged 1 commit into from
May 19, 2024

Conversation

rtjoa
Copy link
Contributor

@rtjoa rtjoa commented Mar 30, 2023

Converting a Ptr to Int errors if the top bit is 1.

Without this change, I ran into errors like the following when calling Cudd_Regular, Cudd_IsComplement, and Cudd_Not:

InexactError: check_top_bit(Int64, 18446744073709547520)

@mykelk
Copy link
Member

mykelk commented Mar 30, 2023

Thanks! I'm happy to merge this if you think it's good to go!

@mykelk
Copy link
Member

mykelk commented Mar 30, 2023

@MaximeBouton do you know why this is failing on Julia 1.8 on Windows? Might the binary need to be rebuilt?

@MaximeBouton
Copy link
Member

MaximeBouton commented Oct 2, 2023

Hi! I am not sure why it breaks because I think we had fixed it in an earlier PR #22

It could very well be that we need to rebuild the binaries in Yggdrasil, I won't be able to look at it before next week-end though.

@MaximeBouton
Copy link
Member

I tested it with julia 1.9.3 on windows, and I get an OOM error but that do not happen all the time. I am getting those warnings too (also getting them with CUDD master)

CUDD: unable to allocate 44828721156 bytes
Unable to set aside memory

CUDD: unable to allocate 44828721156 bytes
Unable to set aside memory

CUDD: unable to allocate 44828721156 bytes
Unable to set aside memory

@mykelk mykelk merged commit 0a55d1e into sisl:master May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants