Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: return to same page we were on after editing a bookmark #26

Closed
MaybeThisIsRu opened this issue Aug 9, 2020 · 3 comments · Fixed by #31
Closed

Enhancement: return to same page we were on after editing a bookmark #26

MaybeThisIsRu opened this issue Aug 9, 2020 · 3 comments · Fixed by #31
Labels
enhancement New feature or request

Comments

@MaybeThisIsRu
Copy link

I am retrospectively trying to add tags to all my bookmarks. Once I reached page 2, edited a bookmark, and saved it, I was redirected back to the homepage (page 1). I'm having to manually go back to page 2 and edit the next bookmark.

A good UX would be to go back to the same page we were on before hitting the edit button.

@MaybeThisIsRu
Copy link
Author

This appears to be configured here. Since we don't know what page we were on when we opened the edit form, this might involve either checking the user history at the server level (redirect to last known bookmark index page with pagination) or by attaching a new parameter in the form data itself.

Both solutions look to be rather odd, but I'm thinking out loud here. 🤷‍♀️

@sissbruecker
Copy link
Owner

@hirusi Thanks, this is a very sensible request. I implemented a solution where the app redirects to the filtered / paged view after editing or deleting a bookmark.

The technical solution was a bit involved, but in general the bookmark index view simply passes a return_url param to the edit / delete views. These views can then use that param to redirect to that URL after executing their logic.

@sissbruecker
Copy link
Owner

@hirusi Also feel free to test this a little bit, I had to make quite a few changes around several redirects.

I'll try to make a Docker release now.

@sissbruecker sissbruecker added the enhancement New feature or request label Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants