Feature/integrate lisk #63
Conversation
foxy7595
force-pushed
the
feature/integrate-lisk
branch
2 times, most recently
from
50fa2fa
to
e7e397e
Compare
foxy7595
force-pushed
the
feature/integrate-lisk
branch
2 times, most recently
from
11bad92
to
98341b8
Compare
foxy7595
force-pushed
the
feature/integrate-lisk
branch
from
98341b8
to
f731212
Compare
chains/lisk/client.go
Outdated
| } | ||
|
|
||
| var responseObject types.ResponseWrapper | ||
| json.Unmarshal(responseData, &responseObject) |
There was a problem hiding this comment.
json.Unmarshal returns error. Make sure you catch that error here.
chains/lisk/client.go
Outdated
| latestBlock := blocks[0] | ||
| latestBlockJson, _ := json.Marshal(latestBlock) | ||
| var block types.Block | ||
| if err := json.Unmarshal(latestBlockJson, &block); err != nil { |
There was a problem hiding this comment.
You can do
block, ok := latestBlock.(*types.Block)
chains/lisk/client.go
Outdated
| return nil, err | ||
| } | ||
| var block types.Block | ||
| if err := json.Unmarshal(latestBlockJson, &block); err != nil { |
There was a problem hiding this comment.
block, ok := latestBlock.(*types.Block)
There was a problem hiding this comment.
Im using a map so we can't convert from map to interface
When I apply your code , I got this error invalid operation: latestBlock (variable of type map[string]interface{}) is not an interface
chains/lisk/client.go
Outdated
| } | ||
| var transactions []types.Transaction | ||
| if err := json.Unmarshal(transactionsJson, &transactions); err != nil { | ||
| if err != nil { |
chains/lisk/test/main.go
Outdated
| ) | ||
|
|
||
| func testWatcher() { | ||
|
|
| return ret | ||
| } | ||
| func (w *Watcher) acceptTx(tx types.Transaction) bool { | ||
| if tx.Asset.Recipient.Address != "" { |
There was a problem hiding this comment.
You have to do nil checking here for tx.Asset and tx.Asset.Recipient or the app will crash
chains/lisk/test/main.go
Outdated
| @@ -0,0 +1,43 @@ | |||
| package main | |||
There was a problem hiding this comment.
I am moving away from creating a test folder for integration test.
Can you create a watcher_integration_test.go and put this test into that file? The test should have prefix TestIntegration_...
After you are done with the test, add test.Skip() so that the CI system will skip the test
|
You need to write test for the watcher. The test should cover at least 2 basic cases: The watcher should return a list of txs on a new block with interested txs and does not return when there is no tx going through watched address (though there are still txs in the block). You can use in-memory db using |
chains/lisk/mock.go
Outdated
| ethtypes "github.com/ethereum/go-ethereum/core/types" | ||
| ) | ||
|
|
||
| type MockEthClient struct { |
There was a problem hiding this comment.
Why do you mock this for lisk?
| return 0, err | ||
| } | ||
| blocks := responseObject.Data | ||
| latestBlock := blocks[0] |
There was a problem hiding this comment.
Check length of blocks before doing this.
chains/lisk/watcher.go
Outdated
| ) | ||
| txFormatted := ctypes.Tx{ | ||
| Hash: tx.Id, | ||
| Serialized: []byte(tx.Signatures[0]), |
There was a problem hiding this comment.
Check signatures length here
chains/lisk/watcher.go
Outdated
| log.Info(w.cfg.Chain, " Block length = ", block.NumberOfTransactions) | ||
| txArr := make([]*ctypes.Tx, 0) | ||
| for _, tx := range block.Transactions { | ||
| if strings.EqualFold(tx.Sender.Address, w.vault) { |
There was a problem hiding this comment.
Wrong checking. We want to check the recipient of the asset, not the sender.
No description provided.