Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremely slow push function #15

Closed
devinhalladay opened this issue Jul 26, 2013 · 2 comments
Closed

Extremely slow push function #15

devinhalladay opened this issue Jul 26, 2013 · 2 comments

Comments

@devinhalladay
Copy link
Contributor

The siteleaf push theme function is extremely slow.

I'm not sure if it's an API issue (in which case I hope @destroytoday has noticed this and is looking into it already), an issue with the Gem itself, or one of its dependencies.

I've experienced this issue across two computers — one was a PC running Windows 7 64-bit and the other is an MBP running OS X 10.8.4 and the latest version of the SiteLeaf gem. It's safe to say that the issue is persistent across every machine, as the guy who posted #14 seems to be experiencing this issue to some extent.

It could merely be the zip function, because I do have a lot of files that need to be zipped. If that is so, then I think it would be smart to consider other options for packaging the theme for pushing to the server.

@destroytoday
Copy link

We're on it. It's not an API issue, but more of a zipping issue and we need to be smarter about it. Currently, everything is zipped, uploaded, and extracted. This is definitely not smart, but rather MVP. We plan to push only changed files and add an ignore file very soon.

@devinhalladay
Copy link
Contributor Author

Okay, glad to here it's not an API issue.
An idea I've had for only uploading changed files is to create a custom Guard (i.e. guard-siteleaf) and just move the zip function from the Siteleaf gem itself to the Guard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants