PHP Compatibility Checker Fixes #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks. PHP checker has no issues with this branch. Can you confirm that the Circle Icon text, icon, and icon background settings are all still functional for you? They don't seem to be for me but could just be a caching/local issue. |
|
Looking good, thanks mate. |
Misplon
approved these changes
Jun 24, 2020
gregpriday
approved these changes
Jun 30, 2020
Tested locally before merging. Edited comment to add spacing. Co-authored-by: Greg Priday <greg@siteorigin.com>
|
Are you able to build this branch? I don't seem to be able to:
|
|
Cool, I've resolved for a build but perhaps you can resolve via a commit. Thanks! |
|
This PR branch passes the PHP 7.3 checker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resole #358. Related comment
This PR avoids a bug with the PHPCS version PHP Compatibility Checker is using. Basically, it has trouble with inline control structures without braces.
@Misplon I can't seem to get PHP Compatibility Checker to check Vantage quickly enough to avoid a timeout locally so you may need to use a website you have access too to confirm this PR helps.