-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix initiator and update package lock #9
Conversation
Strange, |
Also, I found that the CI has failed with the precedent commit https://travis-ci.org/sitespeedio/chrome-har/jobs/322701738 too. Do I have to change something in the code or does the CI criteria (or the linter in the code) have to be change ? Thanks 😄 |
index.js
Outdated
const topCallFrame = params.initiator.stack.callFrames[0]; | ||
entry._initiator = topCallFrame.url; | ||
entry._initiator_line = topCallFrame.lineNumber + 1; // Because lineNumber is 0 based | ||
entry._initiator_column = topCallFrame.columnNumber; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also 0-based, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk, will check 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's 0 based https://chromedevtools.github.io/devtools-protocol/1-2/Runtime#type-CallFrame
Will commit the fix
Since we don’t lock down dev dependencies, the version of prettier that’s the current at the time will be run. There are sometimes small formatting changes to prettier, so a previously green build might shift to red, just by running npm install at a later time. Not ideal, we should probably lock it down, at least to a major version. I can have a closer look, hopefully later tonight. Changes look awesome btw. =) |
Hello,
I fixed the initiator, its now have different properties according to its type property:
For all type:
Parser type:
Script type:
And I updated the package.lock.json
Thanks 😄