This repository has been archived by the owner on May 16, 2024. It is now read-only.
Add ability to sort advices based on cli arguments #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lapa182
changed the title
lapa182
force-pushed
the
feature/add-sortoption-adviceInfo#222
branch
2 times, most recently
from
12be68c
to
dbd5eae
Compare
tobli
suggested changes
Feb 6, 2017
lib/table.js
Outdated
| @@ -3,6 +3,8 @@ | |||
| var wrap = require('word-wrap'); | |||
|
|
|||
| var Table = require('cli-table2'), | |||
| argv = require('yargs').argv, | |||
There was a problem hiding this comment.
Put the definition of the sortBy option into cli.js (with documentation). I suggest a choice of 'name' and 'score', with a default of 'name'. Then make sortProperty an argument to getNewTable.
lib/table.js
Outdated
| @@ -3,6 +3,8 @@ | |||
| var wrap = require('word-wrap'); | |||
|
|
|||
| var Table = require('cli-table2'), | |||
| argv = require('yargs').argv, | |||
| _ = require('lodash'), | |||
There was a problem hiding this comment.
'lodash' is not a dependency in package.json. Just depend on 'lodash.sortBy' (making sortProperty an argument you can skip _.isUndefined).
lib/table.js
Outdated
|
|
||
| let sortedAdvice; | ||
|
|
||
| sortedAdvice = sortProperties(adviceList, argv.sortBy); |
There was a problem hiding this comment.
while the changes above, you can simplify this to
sortedAdvice = sortBy(adviceList, sortProperty);
Added ability to sort advices based on cli arguments
lapa182
force-pushed
the
feature/add-sortoption-adviceInfo#222
branch
from
20e683b
to
cc0eb53
Compare
|
@tobli done :D! |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm testand test linting bynpm run lintDescription
Add the ability to sort advices list based on the cli argument (--sortBy=), if no argument is passed set name as default. This is the pull request for the feature #222