BUGFIX: fix "breakpoint-max" generating invalid CSS #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to using a nonexistent "number()" function, the breakpoint-max mixin
generated invalid CSS ("number(foo)") was passed through to CSS. Fixed it
by removing the function and outputting the result in em, similar to the
"breakpoint-min" mixin.
|
Thanks for bringing this up. I'll get this merged into the master branch now. A new tag release v1.5 will be coming within the next few weeks with this included too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to using a nonexistent (at least on my machine and sass version, node-sass 3.8.0, libsass 3.3.6)
number()function, thebreakpoint-maxmixin generated invalid CSS (number(foo)was passed through to CSS). Fixed it by removing the function and outputting the result in em, similar to thebreakpoint-minmixin.