Refactoring #81
Closed
Refactoring #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR marked stale due to no recent activity. |
|
PR closed due to lack of activity for an extended period. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted tests and
Formatinto separate files.Formatted and refactored the code.
Removed
extern crate ....parts as they are not required in the newer versions of Rust.byte_to_coloralso happened to be a part of refactoring as its return type was changed toansi_term::style::Colorbecause anywhere the function was called, the output was wrapped into this enum. Now it's done explicitly within the function itself.