Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API updates #52

Merged
merged 8 commits into from
Apr 16, 2024
Merged

API updates #52

merged 8 commits into from
Apr 16, 2024

Conversation

m-terra
Copy link
Collaborator

@m-terra m-terra commented Apr 15, 2024 •
edited
Loading

allow multiple deny options
add http and tcp checks
add env vars for stateful set

@coveralls
Copy link

coveralls commented Apr 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8703233170

Details

  • 25 of 27 (92.59%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 65.459%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apis/config/v1alpha1/backend_types.go 7 9 77.78%
Totals Coverage Status
Change from base Build 7868829725: 0.2%
Covered Lines: 1211
Relevant Lines: 1850
💛 - Coveralls

xosk31
xosk31 previously approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@xosk31 xosk31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

xosk31
xosk31 previously approved these changes Apr 16, 2024
View reviewed changes
@m-terra m-terra changed the title breaking change: allow multiple deny rules API updates Apr 16, 2024
@m-terra m-terra merged commit dcf0c56 into main Apr 16, 2024
4 checks passed
@m-terra m-terra deleted the api-updates branch April 16, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xosk31 xosk31 xosk31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-terra @coveralls @xosk31