Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to_dictionary() to_lookup() default for Grouping #13

Closed
Sovetnikov opened this issue Jan 2, 2016 · 2 comments
Closed

to_dictionary() to_lookup() default for Grouping #13

Sovetnikov opened this issue Jan 2, 2016 · 2 comments

Comments

@Sovetnikov
Copy link

Just a suggestion, that Grouping.to_dictionary() without key and value selectors must behave as to_dictionary(key_selector=lambda x: x.key, value_selector=lambda x: x.to_list())
Just make dict with key->list_of_values structure.

Same for to_lookup()
@rob-smallshire
Copy link
Collaborator

Good idea!

rob-smallshire added a commit that referenced this issue Jan 2, 2016
@rob-smallshire
Fixed issue #13 – overrides the default selectors used for Grouping.t…
0c4e259 
…o_dictionary() and Lookup.to_dictionary() giving more intuitive behaviour.
@rob-smallshire
Copy link
Collaborator

Closing this issue now that documentation is in place. This change will be included in the next release of asq.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rob-smallshire @Sovetnikov