better errors, clippy, ci #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hopefully improving error messages.
definitely adding clippy (and addressing problems).
improving ci release automation.
update: 8/30/2022 - I tracked this issue down to
lines.next().awaitappearing to not return theBrokenPipeio error the same as manually iterating with severalread_line(...)calls. Instead, aNonevalue was coming back, making it difficult to determine if our connection was dropped. I'm not exactly sure why that is happening, but given there is test coverage targeting real redis servers in CI, this refactor is safe for the time being.