Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify centralized trade algorithm #379

Merged
merged 1 commit into from
Feb 19, 2023
Merged

Simplify centralized trade algorithm #379

merged 1 commit into from
Feb 19, 2023

Conversation

sjanel
Copy link
Owner

@sjanel sjanel commented Feb 19, 2023 •
edited

  • Only one call of placeOrderProcess in the loop.
  • Only one call of computeAvgOrderPrice in the loop.
  • Other code cleanups (less variables, possibility to set minTimeBetweenPriceUpdates to max without bug)
  • Addition of unit tests covering emergency timeout actions

@sjanel sjanel added the refactoring Code cleaning and refactoring label Feb 19, 2023
@sjanel sjanel force-pushed the feature/simplify-trade-algorithm branch from e4e0dd6 to d93e35e Compare February 19, 2023 20:22
@sjanel sjanel force-pushed the feature/simplify-trade-algorithm branch from d93e35e to 7e6be80 Compare February 19, 2023 21:19
@sjanel sjanel merged commit 4510b0c into main Feb 19, 2023
@sjanel sjanel deleted the feature/simplify-trade-algorithm branch February 19, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring Code cleaning and refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sjanel