Refactor common plugin code

[vogdb]

No description provided.

[codecov-io]

Current coverage is 92.04%

Merging #40 into master will decrease coverage by 2.21%

@@             master        #40   diff @@
==========================================
  Files            12         12          
  Lines           488        503    +15   
  Methods         124        127     +3   
  Messages          0          0          
  Branches         61         62     +1   
==========================================
+ Hits            460        463     +3   
- Misses           28         40    +12   
  Partials          0          0          

Powered by Codecov. Last updated by 0dedc3b...5c925c3

[vogdb]

@zazabe please review. It should be easier to review commit-by-commit. Pay special attention to @ 2c11d04

[zazabe]

• e3d2c95
  • I wrote a note about having a generic method to send transactions, then i saw your last commit :) (5c925c3)
  • now I'm wondering, is it really useful to have this TCrudPlugin?
  • why not changing sendWithDefaultTransaction(options) into sendWithTransaction(message, callback), then callback could be executed after the common response['plugindata']['data']['error'] check ?
• 2c11d04:
  OK, get it, I have a better understanding about how it works ;) so if i understand, transaction.execute is just resolving/rejecting the transaction.promise from outside and sendSync has a ref to this transaction.promise and will react to it.
  Sgtm, even if it smells the deferred antipattern a bit, (something external is resolving/rejecting the transaction.promise), it don't think we can really avoid it. We could resolve/reject it based on some event but it will be quite the same :).

[vogdb]

@zazabe please review

[zazabe]

lgtm