Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Signature of Request #1

Closed
sjmog opened this issue Jun 27, 2017 · 7 comments
Closed

Check Signature of Request #1

sjmog opened this issue Jun 27, 2017 · 7 comments

Comments

@sjmog
Copy link
Owner

sjmog commented Jun 27, 2017

Users of this gem should be able to configure signature-checking through it as painlessly as possible.

There is an NPM Package which does this for node-based Alexa skills.

@mattrayner
Copy link
Collaborator

I'll pick this up now 👍 already got a partial implementation

@sjmog
Copy link
Owner Author

sjmog commented Nov 17, 2017

Awesome @mattrayner , thanks so much!

@mattrayner
Copy link
Collaborator

Hi @sjmog,
Off the back of this I've been working on a GEM which can be found here:
https://github.com/mattrayner/alexa_request_verifier

There was already a gem with partial functionality available here:
https://github.com/sidoh/alexa_verifier

I've been in contact with @sidoh about merging our efforts back into his alexa_verifier gem.

In the meantime I have a PR open on my own gem at:
https://github.com/mattrayner/alexa_request_verifier/pulls/1 that adds configuration options into the mix.

If you're happy with the above I'll begin some integration work? Did you have any thoughts here or are you happy for me to just 'have at it'?

@mattrayner
Copy link
Collaborator

Following on from the above message, alexa_request_verifier has now been merged into alexa_verifier and I will begin work on integrating it into ralyxa shortly

@sjmog
Copy link
Owner Author

sjmog commented Dec 4, 2017

Awesome – thank you @mattrayner

Both your verifier and @sidoh's verifier look super-reasonable to me.

Would you be happy to do a doc update to Ralyxa's README, too?

@mattrayner
Copy link
Collaborator

mattrayner commented Dec 4, 2017 via email

@sjmog
Copy link
Owner Author

sjmog commented Jan 4, 2018

Closed by #3

@sjmog sjmog closed this as completed Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants