Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Megalodon translation bug #465

Closed
d4f5409d opened this issue Mar 19, 2023 · 1 comment
Closed

Megalodon translation bug #465

d4f5409d opened this issue Mar 19, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@d4f5409d
Copy link

d4f5409d commented Mar 19, 2023

Describe the bug

A clear and concise description of what the bug is.
Megalodon wants to translate posts that language that match the device language and doesn't want to translate English posts. The account language is set to Hungarian, but the posting language is set to English.

To reproduce
Switch system language to Hungarian
Experience the issue

Does this happen in the official app?

Does this issue also occur with the respective upstream release?
(Please test using the respective upstream-xxxxxx.apk provided in Releases or at least using the current Mastodon version from the Play Store)

No, because it doesn't have a translate button

In case it does, please consider filing an upstream bug report instead.
If this bug is seriously impacting your usage or you think I might want to try to fix it for Megalodon, feel free to still create this issue!

Screenshots and screen recordings

If applicable, add screenshots (and screen recordings, if possible) to help explain your problem.
Screenshot_2023-03-19-22-00-08-93_97294d061ac208a4e8e283a3feb896c9.jpg

No translate button

Screenshot_2023-03-19-22-00-19-12_97294d061ac208a4e8e283a3feb896c9.jpg
Screenshot_2023-03-19-21-59-32-06_97294d061ac208a4e8e283a3feb896c9.jpg

Version

Megalodon version: v1.2.0+fork.77

Crash log

If you know your way around Android development tools, please consider attaching a crash log, if possible.

@d4f5409d d4f5409d added the bug Something isn't working label Mar 19, 2023
@sk22
Copy link
Owner

sk22 commented Mar 20, 2023

in your version, megalodon displays the translate button if your account's default posting language doesn't equal the post's language, but this turned out not to be smart, because the default posting language is null by default and is usually only explicitly set if the language in which you post isn't the same your mastodon web is being displayed in.

mastodon (since the translation happens on the server) only translates into the display language mastodon web is set to - and, unfortunately, there's no way for apps to know what display language you set on mastodon. that said, comparing to the device's display language is my best bet.

in the next release, megalodon will therefore compare the post language to your device's display language instead of your default posting language instead.

more info: #458, and here: https://floss.social/@megalodon/110034192425780504

@sk22 sk22 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants