Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Query user's locale to determine whether to show translation button #458

Closed
sk22 opened this issue Mar 16, 2023 · 2 comments
Closed

Query user's locale to determine whether to show translation button #458

sk22 opened this issue Mar 16, 2023 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@sk22
Copy link
Owner

sk22 commented Mar 16, 2023 •
edited
Loading

re: https://floss.social/@megalodon/110034192425780504
@sk22 sk22 added the bug Something isn't working label Mar 16, 2023
@sk22 sk22 changed the title translate button always showing Query user's locale to determine whether to show translation button Mar 16, 2023
sk22 added a commit that referenced this issue Mar 17, 2023
@sk22
compare status lang to device locale
4db90b8 
re: #458
@sk22 sk22 added the help wanted Extra attention is needed label Mar 17, 2023
@sk22
Copy link
Owner Author

sk22 commented Mar 17, 2023

would have to be able to somehow query the display language / locale set inside mastodon for this to work correctly (as the translation endpoint will always translate to that - so the translation button shouldn't be shown for posts written in the user's display language)… alternatively, the mastodon api could allow a parameter to specify the desired output language.

@sk22
Copy link
Owner Author

sk22 commented Mar 17, 2023

as long as the api doesn't expose this information (or parameter), i think i'll leave it as it is.

@sk22 sk22 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 17, 2023
@sk22 sk22 mentioned this issue Mar 20, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sk22