Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make /pong family-friendly #111

Closed
wants to merge 1 commit into from
Closed

Make /pong family-friendly #111

wants to merge 1 commit into from

Conversation

tmad40blue
Copy link

Previous output of "/pong" was not safe for work; I've made it safe.

I had some parents complain very loudly after their kids got curious and used /pong on my server. I've since aliased it to /ping, but for future server owners who might not know the output of the command upon installing the plugin, it might be good for it to be "safe for work".

I had some parents complain very loudly after their kids got curious and used /pong on my server. I've since aliased it to /ping, but for future server owners who might not know the output of the command it might be good for it to be "safe for work".
@ewized
Copy link
Contributor

ewized commented Jan 19, 2016

/pong requires extra permissions no need to change it. All you have to do
is not lazy give players permissions.

On 20:53, Mon, Jan 18, 2016 Dylan Larkins notifications@github.com wrote:

Previous output of "/pong" was not safe for work; I've made it safe.

I had some parents complain very loudly after their kids got curious and
used /pong on my server. I've since aliased it to /ping, but for future
server owners who might not know the output of the command upon installing

the plugin, it might be good for it to be "safe for work".

You can view, comment on, or merge this pull request online at:

#111
Commit Summary

  • Make /pong family-friendly

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#111.

@DarkArc
Copy link
Member

DarkArc commented Jan 19, 2016

#84

@DarkArc DarkArc closed this Jan 19, 2016
@tmad40blue
Copy link
Author

It seems extremely unprofessional to have a racist, pedophilia-referencing command in your plugin at all. I think that it shouldn't matter how easy it would be to deny permission for/alias it out; it just shouldn't be there in the first place.

@DarkArc
Copy link
Member

DarkArc commented Jan 19, 2016

As it stands, without using an alias, there is no method by which to allow "/ping" but disallow "/pong", thus making the "don't give permission for the command" argument moot.

...
@CommandPermissions({"commandbook.pong"})
...

Thus, "commandbook.pong" is the permission you're looking for -- which should not be given by default anyways -- where as there is not a permission for "/ping". It's a harmless easter egg/prank command added by sk years ago -- sk is of Asian descent, it's just kind of a "oohhhh ___ likes sk!" kind of deal. No one here is endorsing racism, or pedophilia. If you're offended by it, just don't use it, and don't allow other people to use it.

On the same note, I don't see any particular harm in having it so long as permissions are used properly. This is an opt-in feature, evidently you opted in, please look over your permissions.

If this was anything but an open source mod for a game, this most certainly would have been removed long ago. I'm truly sorry for any grief you've received.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants