Skip to content

Remove pointless message from /pong#84

Closed
tonybruess wants to merge 1 commit into
EngineHub:masterfrom
OvercastNetwork:pong-msg
Closed

Remove pointless message from /pong#84
tonybruess wants to merge 1 commit into
EngineHub:masterfrom
OvercastNetwork:pong-msg

Conversation

@tonybruess
Copy link
Copy Markdown
Contributor

I've had to deal with several users asking why this command is in place and saying it's offensive.

Would be best to just remove sk89q's lovely response.

@tonybruess
Copy link
Copy Markdown
Contributor Author

Why keep that message? It's pointless and unprofessional. I Would like this PR reopened.

@sk89q
Copy link
Copy Markdown
Member

sk89q commented Nov 21, 2012

In regards to wiz's commit:

  1. You would not give commandbook.* as a permission by default.
  2. You have to explicitly turn this feature on.
  3. All three stances on the matter are satisfied; that is: don't care, disable it and enable it.

Therefore, for all intents and purposes, his change is more effective. Before any change, the number of options was two. With Wiz, it increase to three. Yours reduces the number of options by one from wiz's change and therefore is the less ideal option of the two.

@tonybruess
Copy link
Copy Markdown
Contributor Author

How's that?

Not only did I include wizjany's change that allows this 'feature' to be disabled, but if it is enabled, there are no surprises.

@sk89q
Copy link
Copy Markdown
Member

sk89q commented Nov 21, 2012

Your latest change makes it functionally equivalent to your original change, for all intents and purposes, and reduces the number of options by one.

For what it's worth, you are the first person I've seen complain about this, and I've only received positive (or neutral) messages regarding this 'function' in the past.

@tonybruess
Copy link
Copy Markdown
Contributor Author

I'm only passing on the complaints of my player base. I've never had issues with it, but I've gotten several messages lately asking why /pong is what it is. This seemed like a straightforward, issue-less change, but apparently you would prefer to keep this 'feature'.

@wizjany
Copy link
Copy Markdown
Collaborator

wizjany commented Nov 21, 2012

It was a straightforward, issue-less change. In fact, I did it in about 5 seconds in vi last night, didn't even bother opening eclipse or running maven.

@sk89q
Copy link
Copy Markdown
Member

sk89q commented Nov 21, 2012

Keeping with wiz's change is also "issue-less" because it hasn't really proven a problem. Now you have the option of disabling it as well.

@ManBeastPig
Copy link
Copy Markdown

This is racist and should be removed, not perms or disabled, but REMOVED. I get complaints most days.

@wizjany
Copy link
Copy Markdown
Collaborator

wizjany commented Mar 3, 2013

add

aliases:
    pong: ping

to your bukkit.yml

@wizjany wizjany mentioned this pull request Jun 23, 2013
@nevercast
Copy link
Copy Markdown

If you find it offensive, remove the permission or alias it as wiz said.

@netizen539
Copy link
Copy Markdown

So is this really enabled by default? I didn't do anything to explicitly enable it and yet, people seem to be able to use it. At best, it allows users to "trick" my unwary admins into typing the command. This really should be removed. I shouldn't have to use some bukkit.yml hack or explicitly disable silly racist and homophobic commands. If I wanted a bunch of pointless commands I'd use Essentials.

@DarkArc
Copy link
Copy Markdown
Member

DarkArc commented Nov 16, 2013

Why are you commenting on a 5 month old pull request? And no there is and has been a permission node for it for quite sometime...

@netizen539
Copy link
Copy Markdown

Because I'm dealing with this issue right now. And I have no permission node enabled for this and yet users can access it. Like I said before even if users CANT access it they can trick admins who have commandbook.* into using it. It's just unprofessional. Why is there two commands to send back a dummy reply in the first place? Surely one is enough?

@ewized
Copy link
Copy Markdown
Contributor

ewized commented Nov 16, 2013

Update commandbook.

@netizen539
Copy link
Copy Markdown

Ok. I'll update commandbook and see if that prevents players from using it. If it does it will solve 50% of the problem. You can still trick admins so I guess I'll just have to deal with the trolls asking "What does /pong do?" every time an admin logs on.

Thanks.

@DarkArc
Copy link
Copy Markdown
Member

DarkArc commented Nov 16, 2013

Or you can just deny the permission node for it...

Sent from Yahoo Mail on Android

@nevercast
Copy link
Copy Markdown

Wow, talking about grave digging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants