Bump all dependencies to the latest for testing #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required some test changes to keep pytest-asyncio 0.23 happy.
For whatever reason, version upgrades now cause an "unclosed transport" ResourceWarning to be emitted if a client is not closed before the event loop. Suppress it.
Python 3.11+ changed the warning for an unclosed transport when the event loop is closed.
ludwigschwardt
approved these changes
Apr 17, 2024
| loop = async_solipsism.EventLoop() | ||
| yield loop | ||
| loop.close() | ||
| def event_loop_policy(): |
There was a problem hiding this comment.
Is this magically picked up?
There was a problem hiding this comment.
Yes, it's a fixture provided by pytest-asyncio>=0.23 for you to override.
| @@ -39,10 +39,8 @@ | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
| def event_loop(): | |||
There was a problem hiding this comment.
What about the owner fixture down below that uses event_loop?
There was a problem hiding this comment.
pytest-asyncio provides the event_loop fixture. It just doesn't want you to override it any more as of 0.23 (doing so is deprecated). It also doesn't want you to directly depend on the fixture in async tests, but it's okay in synchronous fixtures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required some test changes to keep pytest-asyncio 0.23 happy.