-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update versions of various things #177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bmerry
commented
Feb 22, 2022
- Drop support for Python 3.6 (it's end-of-life and was making my life more difficult to support)
- Run tests against Python 3.10 in place of 3.9 (possible now that numba supports 3.10)
- Update all the versions in requirements.txt to the latest supported by Python 3.7
- Update pytest settings to support an update in pytest-asyncio
- Pin setuptools to an older version to work around a bug that prevents wheels being built
- Limit wheel building to manylinux builds (cibuildwheel now also tries to build musllinux wheels, which don't build)
Mostly so that we test against Python 3.10 and build 3.10 wheels against the final release. But I went ahead and bumped all the versions I could see.
Bare 3.10 is a float, so replace with '3.10'. Also fix up the coverage run to use 3.10.
Mainly *downgrading* setuptools to work around a bug, but upgrading pybind11, jinja2, pycparser, cibuildwheel.
It's end-of-life, and was complicating the CI process.
It needs to be pinned in pyproject.toml, not in the outer environment.
Newer cibuildwheel also tries to build musllinux wheels, but the scripts aren't ready for that (they assume yum is the package manager).
Test on Python 3.10.
The default will change to 'strict' in the future, but since asyncio is the only async framework supported, 'auto' makes more sense.
james-smith-za
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.