Sdp integration - Update TMC, CSP, OET, SDP image versions #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kalyanithigale
commented
Oct 3, 2019
•
kalyanithigale
commented
- Update TMC, CSP, OET and SDP image versions which have support for latest PyTango and Tango images.
- To resolve some issues in CSP devices, added ping statements for dependant devices as suggested by Elisabetta.
kalyanithigale
changed the title
Matteo04052017
requested changes
Oct 3, 2019
charts/csp-proto/values.yaml
Outdated
| @@ -18,15 +18,15 @@ csplmc: | |||
| image: | |||
| registry: nexus.engageska-portugal.pt/ska-docker | |||
| image: csplmc | |||
| tag: 0.1.0 | |||
| tag: 0.1.4 | |||
| pullPolicy: Always | |||
There was a problem hiding this comment.
Why do you put Always as pullPolicy if the tag is not latest? Change to IfNotPresent.
There was a problem hiding this comment.
Changed pullPolicy to IfNotPresent.
Commit Id: c3e714b
charts/csp-proto/values.yaml
Outdated
| pullPolicy: Always | ||
|
|
||
| midcbfmcs: | ||
| enabled: true | ||
| image: | ||
| registry: nexus.engageska-portugal.pt/ska-docker | ||
| image: mid-cbf-mcs | ||
| tag: 0.1.0 | ||
| tag: 0.1.2 | ||
| pullPolicy: Always |
There was a problem hiding this comment.
same comment as above
charts/oet/values.yaml
Outdated
| @@ -10,7 +10,7 @@ oet: | |||
| image: | |||
| registry: nexus.engageska-portugal.pt/ska-telescope | |||
| image: oet-ssh | |||
| tag: 0.2.8 | |||
| tag: 0.2.9 | |||
| pullPolicy: Always | |||
| @@ -74,7 +74,7 @@ spec: | |||
| env: | |||
| - name: TANGO_HOST | |||
| value: databaseds-tango-base-{{ .Release.Name }}:10000 | |||
| image: nexus.engageska-portugal.pt/sdp-prototype/tangods_sdp_master:0.2.1 | |||
| image: nexus.engageska-portugal.pt/sdp-prototype/tangods_sdp_master:0.2.3 | |||
| imagePullPolicy: Always | |||
There was a problem hiding this comment.
change to IfNotPresent
| @@ -87,7 +87,7 @@ spec: | |||
| value: "0" | |||
| - name: SDP_CONFIG_HOST | |||
| value: {{ include "sdp-prototype.etcd-host" . }} | |||
| image: nexus.engageska-portugal.pt/sdp-prototype/tangods_sdp_subarray:0.5.12 | |||
| image: nexus.engageska-portugal.pt/sdp-prototype/tangods_sdp_subarray:0.5.16 | |||
| imagePullPolicy: Always | |||
There was a problem hiding this comment.
change to IfNotPresent
charts/tmc-proto/values.yaml
Outdated
| @@ -18,7 +18,7 @@ tmcprototype: | |||
| image: | |||
| registry: nexus.engageska-portugal.pt/tango-example | |||
| image: tmcprototype | |||
| tag: latest | |||
| tag: 0.1.3 | |||
| pullPolicy: Always | |||
There was a problem hiding this comment.
change to IfNotPresent
Matteo04052017
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.