Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use zeromq everywhere in sgxwallet #273

Closed
sync-by-unito bot opened this issue Mar 1, 2021 · 5 comments
Closed

use zeromq everywhere in sgxwallet #273

sync-by-unito bot opened this issue Mar 1, 2021 · 5 comments
Assignees
@olehnikolaiev

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Mar 1, 2021 •
edited
Loading

use zeromq instead of json-rpc server for all methods. it will increase performance and remove possible memory leaks

┆Issue is synchronized with this Jira Story
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 3, 2021

➤ Ganna Kulikova commented:

Post IMA/June release

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 8, 2021

➤ Automation for Jira commented:

Corresponding Pull Request #326

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 23, 2021

➤ Automation for Jira commented:

Corresponding Pull Request skalenetwork/sgx.py#111

@sync-by-unito sync-by-unito bot closed this as completed Jul 7, 2021
@sync-by-unito sync-by-unito bot reopened this Jul 20, 2021
@sync-by-unito sync-by-unito bot closed this as completed Aug 2, 2021
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 4, 2021

➤ Oleksandr Salamatov commented:

Oleh Nikolaiev please add steps to test

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 4, 2021

➤ Oleh Nikolaiev commented:

for now only unit tests are available, because zmq is not integrated into node components. suggest to close this one as far as unit tests are passing and test zmq later when it will be added into admin, node-cl, transaction manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olehnikolaiev olehnikolaiev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olehnikolaiev