Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

[Improvement] Use docker api to attach container #52

Closed
skanehira opened this issue Jan 25, 2019 · 1 comment
Closed

[Improvement] Use docker api to attach container #52

skanehira opened this issue Jan 25, 2019 · 1 comment

Comments

@skanehira
Copy link
Owner

skanehira commented Jan 25, 2019 •
edited
Loading

related:
#38

now:
When attach container docui call docker attach internally.

after:
Use docker api exec create exec start to attach container.
skanehira added a commit that referenced this issue Jan 25, 2019
@skanehira
chnage container attach use go-dockerclient #52
0baf224
@skanehira skanehira mentioned this issue Jan 25, 2019
Merged
skanehira added a commit that referenced this issue Jan 25, 2019
@skanehira
Merge pull request #53 from skanehira/develop
90bb693 
use docker api to attach container #52
skanehira added a commit that referenced this issue Jan 25, 2019
@skanehira
Fixed docker image build.sh #52
488811a
@skanehira
Copy link
Owner Author

This was completed.

@skanehira skanehira mentioned this issue Jan 25, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skanehira