Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#76: Draft implementation #82

Merged
merged 1 commit into from
Jul 12, 2018
Merged

#76: Draft implementation #82

merged 1 commit into from
Jul 12, 2018

Conversation

skapral
Copy link
Owner

@skapral skapral commented Jul 12, 2018

Closes #76

Root cause of the issue

N/A

Description of the changes

Added support for X-Gitlab-Token. In case of mismatch, event is rejected.

Checklist

  • No classes in this PR were explicitly annotated with @Atom or @NotAtom annotation,
    or the reason for such intention is provided in PR description.

@codecov
Copy link

codecov bot commented Jul 12, 2018

Codecov Report

Merging #82 into master will increase coverage by 0.14%.
The diff coverage is 73.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #82      +/-   ##
============================================
+ Coverage     66.24%   66.39%   +0.14%     
- Complexity       93       96       +3     
============================================
  Files            53       55       +2     
  Lines           477      491      +14     
  Branches         17       18       +1     
============================================
+ Hits            316      326      +10     
- Misses          156      159       +3     
- Partials          5        6       +1
Impacted Files Coverage Δ Complexity Δ
...l/puzzler/gitlab/config/Cp_GITLAB_HOOK_SECRET.java 0% <0%> (ø) 0 <0> (?)
...ub/operation/OpValidatingGithubEventSignature.java 90.9% <100%> (ø) 4 <1> (?)
...gitlab/operation/OpValidatingGitlabEventToken.java 83.33% <83.33%> (ø) 3 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc462e0...a0661f6. Read the comment docs.

@skapral skapral merged commit 433dd1c into master Jul 12, 2018
@skapral skapral deleted the issue/76 branch July 12, 2018 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant