Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WriteKnownHost for IPv6 #1 #2

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Fix WriteKnownHost for IPv6 #1 #2

merged 1 commit into from
Jul 7, 2023

Conversation

lonnywong
Copy link
Contributor

evanelias
evanelias approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@evanelias evanelias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, thank you for the excellent PR! I'll merge momentarily. I'll likely tag a new release next week.

knownhosts.go Show resolved Hide resolved
knownhosts_test.go Show resolved Hide resolved
@evanelias evanelias merged commit 6b50f2e into skeema:main Jul 7, 2023
@lonnywong
Copy link
Contributor Author

@evanelias Thanks for merging quickly. I can use it without tag now.

lonnywong added a commit to trzsz/knownhosts that referenced this pull request Sep 16, 2023
@lonnywong
Omit the IPv6 zone ID if it contains spaces skeema#2
2b37a27
@Porkepix Porkepix mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanelias evanelias evanelias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipv6: missing port in address
2 participants
@lonnywong @evanelias