Pass through JSON.stringify optional arguments #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON.stringify takes two optional arguments. This change simply allows passing these arguments through Resurrect's stringify to the underlying call to JSON.stringify. In particular this is useful if certain Object properties should not be included in the serialized JSON (this can be accomplished with the replacer arg).
|
I'm not sure the space argument has any value here, but I could see how the replacer might be useful. |
|
Agreed. I needed the replacer. I figured I'd add both optional arguments for the sake of consistency. I don't have any concerns if you remove the space argument. |
|
I just added two commits, 76f78f8 and 7ce6ad8, that silently wrap the provided replacer so that it doesn't interfere with the intrusive ResurrectJS properties. I don't want the user to be concerned with those details, pretending that this is basically just a smarter JSON.stringify(). I want to know if you think this makes sense. |
|
Makes perfect sense. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON.stringify takes two optional arguments. This change simply allows passing these arguments through Resurrect's stringify to the underlying call to JSON.stringify. In particular this is useful if certain Object properties should not be included in the serialized JSON (this can be accomplished with the replacer arg).