Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker for windows or linux and a line ending problem? #9

Closed
mikereape opened this issue Jul 29, 2021 · 2 comments
Closed

docker for windows or linux and a line ending problem? #9

mikereape opened this issue Jul 29, 2021 · 2 comments

Comments

@mikereape
Copy link

Hi sorry to be so thick. Four questions probably all with obvious answers:

  1. Is the docker container to be built on Windows or Linux? I assumed Windows.
  2. If Windows, in a Windows container or a Linux container?
  3. What if Docker, which I've just re-installed, tells me that it now uses wsl2 for the backend?
  4. If you look at the snippet I've attached it looks to me like an old-fashioned Unix/Linux vs. DOS.Win line endnig problem when it's doing the sha256sum's but what are the '$' signs all about? They''re not in the Dockerfile.

Please forgive a Docker newbie for asking daft questions.

BTW, I'm a fan of your work. I've been folllowinng you for over a year. If you knew anything about me at all you would know that that statement is not a lame attempt to ingratiate myself.

Thanks very much in advance
Mike
sha256sums log.txt

@skeeto
Copy link
Owner

skeeto commented Jul 29, 2021 via email

@skeeto skeeto closed this as completed in ae5c813 Jul 30, 2021
skeeto added a commit that referenced this issue Jul 30, 2021
This misfeature corrupts checkouts on Windows. Closes #9 and #10.
@mikereape
Copy link
Author

HI I just want to thank you for your suggestions. That all worked a treat. I am poised to put it to heavy use immimently. Two comments however. While I am completely sympathetic to static builds only, of late I've come across a bunch of things which in Linuxland build .so files. IIRC neovim does and if you proceed with a static build ultimately it just breaks in the end. Something to think about maybe. Second comment is, again of late, I've come across a lot of projects that use cmake even in Linux projects. Again, neovim is one of them though I suspect they do that precisely because they do cross-platform builds including for Windows. Maybe something else to think about. Very very well done indeed. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants