Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Test unicode emails #18

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/tests.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
["test@nominet.org.uk", "valid"],
["test@about.museum", "valid"],
["a@iana.org", "valid"],
["êjness@iana.com", "valid"],
["ñoñó1234@iana.com", "valid"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skeggse even with unicode character support, this fails on the DNS lookup because of iana.com vs iana.org.

["伊昭傑@郵件.商務", "valid"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skeggse same DNS issue here. The MX resolution fails for 郵件.商務

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, gotcha.

This is a good problem to notice. This also indicates that unicode support in the domain names will break checkDNS, as the resolve family of functions are not unicode compatible or aware, which goes back to my question about punycode. It seems we'll need just a little more to avoid breaking existing functionality in unexpected ways.

["test@e.com", "dnsWarnNoRecord"],
["test@iana.a", "dnsWarnNoRecord"],
["test.test@iana.org", "valid"],
Expand Down